Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wiki #3537

Merged
merged 6 commits into from
Aug 6, 2023
Merged

Fix wiki #3537

merged 6 commits into from
Aug 6, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Jul 31, 2023

Part of solution to #3521
Change the logic to get the right Wiki for board on flasher tab.

Logic to find right url are:

  1. if board description exist in https://betaflight.com/docs/wiki/boards/ + target name
  2. if no board description found, show board missing = https://betaflight.com/docs/wiki/boards/missing

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Aug 1, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@HThuren
Copy link
Member Author

HThuren commented Aug 1, 2023

@blckmn @haslinghuis
compare of bords files .md and unified target files .config looks like we need to rename the boardfiles to same convention than unified target files, ie. KAKUTEH7.md -> HBRO-KAKUTEH7.md
Will require a change to this PR

What do you think ?

@haslinghuis
Copy link
Member

Firmware 4.5 has only the board name in the config file.

Probably focus on 4.5 first. Board name should be used as wiki page (file name) on betaflight.com - so we might have to rename some - didn't check).

@haslinghuis haslinghuis added this to the 10.10.0 milestone Aug 1, 2023
@HThuren
Copy link
Member Author

HThuren commented Aug 2, 2023

Firmware 4.5 has only the board name in the config file.

Probably focus on 4.5 first. Board name should be used as wiki page (file name) on betaflight.com - so we might have to rename some - didn't check).

OK, I understand you mean - no rename. Then the PR are are ready to merge.

PS. we have 138 board documentation and 376 unified target files

src/js/utils/common.js Outdated Show resolved Hide resolved
Co-authored-by: Mark Haslinghuis <[email protected]>
src/js/utils/common.js Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Co-authored-by: Mark Haslinghuis <[email protected]>
@github-actions

This comment has been minimized.

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

"https://betaflight.com/docs/wiki/boards/missing" is a 404 page; is this what is desired?

@haslinghuis
Copy link
Member

@nerdCopter yes see: betaflight/betaflight.com#207 😬

@haslinghuis haslinghuis merged commit 058ab5b into betaflight:master Aug 6, 2023
@HThuren HThuren deleted the fixWiki branch August 6, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

4 participants