Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPS updates #3527

Merged
merged 3 commits into from
Aug 3, 2023
Merged

GPS updates #3527

merged 3 commits into from
Aug 3, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jul 24, 2023 •
edited
Loading

Changes:

  • GPS auto_baud is no longer used in firmware 4.5
  • Rename GPS_UNIT_CONNECTION to GPS_CONNECTION
  • Signal Strength progress bar to meter and adjust range to 0-55:

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jul 24, 2023
@haslinghuis haslinghuis self-assigned this Jul 24, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Jul 24, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis changed the title Remove auto_baud GPS updates Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis requested a review from nerdCopter August 2, 2023 16:54
@nerdCopter
Copy link
Member

unable to test, as i have no GPS

@haslinghuis haslinghuis merged commit 4204281 into betaflight:master Aug 3, 2023
@haslinghuis haslinghuis deleted the remove-autobaud branch August 3, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@McGiverGim McGiverGim McGiverGim approved these changes

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

@blckmn blckmn Awaiting requested review from blckmn

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

Assignees

@haslinghuis haslinghuis

Labels
Cleanup RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @nerdCopter @McGiverGim @ctzsnooze