Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When use magnetometer, add North symbol to GPS position icon #3484

Merged
merged 2 commits into from
Jun 20, 2023
Merged

When use magnetometer, add North symbol to GPS position icon #3484

merged 2 commits into from
Jun 20, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Jun 18, 2023 •
edited
Loading

This PR add N symbol to position icon at GPS map to indicate when the Magentometer are active.
Also make translation possible for GPS position unit in gps.js and setup.js

image

@HThuren HThuren changed the title Add North when use magnetometer Add North when use magnetometer to GPS position icon Jun 18, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Jun 18, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@HThuren HThuren changed the title Add North when use magnetometer to GPS position icon Add North symbol when use magnetometer to GPS position icon Jun 18, 2023
@HThuren HThuren changed the title Add North symbol when use magnetometer to GPS position icon When use magnetometer, add North symbol to GPS position icon Jun 18, 2023
haslinghuis
haslinghuis reviewed Jun 18, 2023
View reviewed changes
src/js/tabs/map.js Outdated Show resolved Hide resolved
@HThuren @haslinghuis
Update src/js/tabs/map.js
aaa0dc2 
Co-authored-by: Mark Haslinghuis <[email protected]>
@haslinghuis haslinghuis added this to the 10.10.0 milestone Jun 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member

Using Virtual Mode:

image

@haslinghuis haslinghuis merged commit 50554c1 into betaflight:master Jun 20, 2023
@HThuren HThuren deleted the GPSiconWithNorthSymbol branch June 20, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@HThuren HThuren

Labels
Ready to Merge RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HThuren @blckmn @haslinghuis @nerdCopter