-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flasher tab: remember last user selected radio protocol #3475
Flasher tab: remember last user selected radio protocol #3475
Conversation
c30082b
to
b4a6db6
Compare
This comment has been minimized.
This comment has been minimized.
b4a6db6
to
3b5847c
Compare
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
This should work for 4.4.3+: betaflight/betaflight#12876 |
@limonspb as this code won't be needed for 4.5.0 anymore would like some semver conditions added - but actually we should reject the change:
Shame there is no |
lots of people will be upgrading from 4.2 4.3, from 4.4.0, from 4.4.1, and from 4.4.2. Heck, there are people still on 4.0 lol. |
assuming they all have the same receivers. Soon everyone will at least be flashing 4.4.3 :) @McGiverGim what's your opinion? This PR assumes configurator will be released before 4.5.0. Sure have no problem with that but it should be coupled at least with 4.4.3 and introduce a feature freeze (unless its 10.9.1). Rather have some more time to test nightly builds for now. 4.5.0 should not take too long as products are already out there. |
thats overestimation that everyone will be on 4.4.3 :) And this PR does not change anything for 4.4.3+ people. |
I think is useful. In my case, for example, I'm on FrSky FPORT, that is not selected automatically. I have few drones, but if someone has some dotzens then it's useful. The same can be done for some "extra" flags, like MAG or similar. |
@limonspb please rebase so we can merge this. |
3b5847c
to
d304ba7
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Do you want to test this code? Here you have an automated build: |
Flasher tab.
Stores the last radio protocol selected by the user into localStorage.
Sets radio protocol dropdown to the last selected value (if value is present in the list, otherwise shows default value)
Update: everything is ignored if buildkey is present = radio protocol is loaded from buildkey.