Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flasher tab: remember last user selected radio protocol #3475

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

limonspb
Copy link
Member

@limonspb limonspb commented Jun 8, 2023

Flasher tab.
Stores the last radio protocol selected by the user into localStorage.
Sets radio protocol dropdown to the last selected value (if value is present in the list, otherwise shows default value)
Update: everything is ignored if buildkey is present = radio protocol is loaded from buildkey.

@limonspb limonspb force-pushed the Flasher_protocol_memory branch 2 times, most recently from c30082b to b4a6db6 Compare June 8, 2023 10:36
@github-actions

This comment has been minimized.

@limonspb limonspb force-pushed the Flasher_protocol_memory branch from b4a6db6 to 3b5847c Compare June 8, 2023 11:18
@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Jun 8, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

This should work for 4.4.3+: betaflight/betaflight#12876

@limonspb limonspb requested a review from blckmn June 13, 2023 07:29
@haslinghuis
Copy link
Member

haslinghuis commented Jun 13, 2023

@limonspb as this code won't be needed for 4.5.0 anymore would like some semver conditions added - but actually we should reject the change:

  • it would already be fixed in 4.4.3 in #12876
  • PR only works if using one specific type of receiver.
  • in a mixed environment this only adds extra maintenance.

Shame there is no #USE_IF_IAM_NOT_LAZY macro 😛 🙈

@limonspb
Copy link
Member Author

limonspb commented Jun 14, 2023

@limonspb as this code won't be needed for 4.5.0 anymore would like some semver conditions added - but actually we should reject the change:

  • it would already be fixed in 4.4.3 in #12876
  • PR only works if using one specific type of receiver.
  • in a mixed environment this only adds extra maintenance.

Shame there is no #USE_IF_IAM_NOT_LAZY macro 😛 🙈

lots of people will be upgrading from 4.2 4.3, from 4.4.0, from 4.4.1, and from 4.4.2. Heck, there are people still on 4.0 lol.
This PR does not change anything, if you are already at 4.5 or 4.4.3, but it helps to others who upgrading from older versions with multiple drones. Thats the only purpose.
If someone has drones with different receivers - they need to select protocol either way. Some people (or most of them?) got same RXes on multiple drones, so at least we can save a couple of clicks for them :)

@haslinghuis
Copy link
Member

haslinghuis commented Jun 14, 2023

but it helps to others who upgrading from older versions with multiple drones.

assuming they all have the same receivers. Soon everyone will at least be flashing 4.4.3 :)

@McGiverGim what's your opinion?

This PR assumes configurator will be released before 4.5.0. Sure have no problem with that but it should be coupled at least with 4.4.3 and introduce a feature freeze (unless its 10.9.1). Rather have some more time to test nightly builds for now.

4.5.0 should not take too long as products are already out there.

@limonspb
Copy link
Member Author

limonspb commented Jun 14, 2023

but it helps to others who upgrading from older versions with multiple drones.

assuming they all have the same receivers. Soon everyone will at least be flashing 4.4.3 :)

@McGiverGim what's your opinion?

This PR assumes configurator will be released before 4.5.0. Sure have no problem with that but it should be coupled at least with 4.4.3 and introduce a feature freeze (unless its 10.9.1). Rather have some more time to test nightly builds for now.

4.5.0 should not take too long as products are already out there.

thats overestimation that everyone will be on 4.4.3 :) And this PR does not change anything for 4.4.3+ people.

@McGiverGim
Copy link
Member

@McGiverGim what's your opinion?

I think is useful. In my case, for example, I'm on FrSky FPORT, that is not selected automatically. I have few drones, but if someone has some dotzens then it's useful. The same can be done for some "extra" flags, like MAG or similar.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jun 14, 2023
@haslinghuis
Copy link
Member

@limonspb please rebase so we can merge this.

@limonspb limonspb force-pushed the Flasher_protocol_memory branch from 3b5847c to d304ba7 Compare June 15, 2023 11:58
@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit e683231 into betaflight:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

4 participants