Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change blackbox debug #3381

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Change blackbox debug #3381

merged 1 commit into from
Mar 17, 2023

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 17, 2023
@haslinghuis haslinghuis self-assigned this Mar 17, 2023
@github-actions

This comment has been minimized.

Sign in to view
@ctzsnooze
Copy link
Member

Brilliant - the blackbox mode selector works MUCH better now than before!
Thank you!

@haslinghuis haslinghuis requested a review from nerdCopter March 17, 2023 23:14
@haslinghuis haslinghuis force-pushed the change-blackbox-debug-field branch from b5138c1 to 357cab7 Compare March 17, 2023 23:20
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

nerdCopter commented Mar 17, 2023 •
edited
Loading

i'm not sure what the changes at src/js/tabs/onboard_logging.js line 352 does.
i see it removes sorting (sortSelect2), but unsure what sortSelect NONE does.

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member Author

On request from Chris I have removed select2.
The NONE param keeps that value on top while sorting the remainder of the list.

@haslinghuis haslinghuis merged commit 43e080b into betaflight:master Mar 17, 2023
@haslinghuis haslinghuis deleted the change-blackbox-debug-field branch March 17, 2023 23:59
@ctzsnooze
Copy link
Member

Absolutely fantastic. Works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @ctzsnooze @nerdCopter