Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Config inserter #3217

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Refactor: Config inserter #3217

merged 1 commit into from
Jan 6, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Jan 6, 2023 •
edited
Loading

No description provided.

@blckmn blckmn added this to the 10.9.0 milestone Jan 6, 2023
@blckmn blckmn self-assigned this Jan 6, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member Author

blckmn commented Jan 6, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn blckmn removed the Don't merge label Jan 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

chmelevskij
chmelevskij reviewed Jan 6, 2023
View reviewed changes
src/js/ConfigInserter.js
@@ -87,21 +83,24 @@ function generateData(firmware, input, startAddress) {

const CONFIG_LABEL = `Custom defaults inserted in`;

ConfigInserter.prototype.insertConfig = function (firmware, config) {
console.time(CONFIG_LABEL);
export default class ConfigInserter {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@haslinghuis haslinghuis merged commit 3a6ea29 into betaflight:master Jan 6, 2023
@blckmn blckmn deleted the config_inserter branch January 7, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

Assignees

@blckmn blckmn

Labels
Cleanup RN: REFACTOR
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@blckmn @chmelevskij @haslinghuis