Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sort function #3167

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Update sort function #3167

merged 1 commit into from
Dec 28, 2022

Conversation

haslinghuis
Copy link
Member

Use JQuery instead of QuerySelector

@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 27, 2022
@haslinghuis haslinghuis self-assigned this Dec 27, 2022
@haslinghuis haslinghuis mentioned this pull request Dec 27, 2022
Merged
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Dec 27, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

McGiverGim
McGiverGim requested changes Dec 28, 2022
View reviewed changes
src/js/utils/common.js Outdated
if (b.text === text) {
return 1;
}
return a.text.localeCompare(b.text, window.navigator.language, { ignorePunctiaton: true });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the localeCompare does not complain about typos :)

Suggested change
return a.text.localeCompare(b.text, window.navigator.language, { ignorePunctiaton: true });
return a.text.localeCompare(b.text, window.navigator.language, { ignorePunctuation: true });

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and it seems to work, strange ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose simply ignores the parameter, and not ignores de punctuation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://reference.wolfram.com/language/ref/IgnorePunctuation.html :)

@sonarcloud
Copy link

sonarcloud bot commented Dec 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 1f7e779 into betaflight:master Dec 28, 2022
@haslinghuis haslinghuis deleted the update-sort-funcion branch December 28, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HThuren HThuren HThuren left review comments

@sugaarK sugaarK sugaarK approved these changes

@McGiverGim McGiverGim McGiverGim approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: REFACTOR
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @McGiverGim @sugaarK @HThuren