Add HD OSD support #3071
Add HD OSD support #3071
Conversation
|
I think I prefer the dashed background (like here #3008 and not the checked one. Other thoughts? |
|
It’s just an image (or rather a set of three). I think the old dashed one looked a bit clunky, hence this suggestion. Happy to use whatever image people find clearest. |
|
The link I posted removes the background image and uses css to draw it. |
|
AUTOMERGE: (FAIL)
|
|
@McGiverGim Yes, I appreciate that. Both PRs take the obvious step of defining |
|
Please verify the unit tests. Is detecting position declared twice. |
SteveCEvans
force-pushed
the
hd_osd
branch
2 times, most recently
from
31dcecb to
552b1f6
Compare
This comment has been minimized.
This comment has been minimized.
|
Ignore me.... i kept reading and see the above has already been done; and even better that variable grid sizes signalled by the video system have been added. Nice work!! 🥳 |
|
Flashed the firmware as there is some issue after saving to HD on OSD tab and going to motors tab.
After several manual connection attempts it went into DFU mode (only once). |
SteveCEvans
requested review from
haslinghuis and
McGiverGim
and removed request for
haslinghuis
| if (videoType === 'AUTO') { | ||
| videoType = 'PAL'; | ||
| } |
There was a problem hiding this comment.
One question. We have a way to know if there is an HD system configured/attached? I don't have the device, so I'm not sure if we have this information. In this case it will be interesting to select HD and not PAL here.
There was a problem hiding this comment.
What I could do is change the firmware so that if a MSP_SET_OSD_CANVAS command is received, the vcd_video_system could be set to HD. If a save is done subsequent to that with the VTX connected, then both that and the canvas size would be preserved and used even if the VTX isn't powered.
There was a problem hiding this comment.
Is not enough if MSP+Displayport is selected? Is simply a best effort, we let the user modify it if needed.
There was a problem hiding this comment.
MSP VTX and displayport are one combined option and don’t necessarily mean HD.
SteveCEvans
requested review from
McGiverGim and
haslinghuis
and removed request for
McGiverGim
|
@SteveCEvans guess you didn't notice the back ticks here otherwise the ${var} template literal is not expanded https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals |
This comment has been minimized.
This comment has been minimized.
|
Will review once changes made.. really happy this got bumped to 10.9 this is a big feature that will make the new release more exciting for the people |
This comment has been minimized.
This comment has been minimized.
|
@SteveCEvans what’s the B concuss on the @KarateBrot changes ? |
Co-authored-by: Jan Post <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
Adds support for HD OSD, standardising on a 53x20 grid, utilising 24x36 fonts for 720P and 36x54 fonts for 1080P.
Grids for NTSC, PAL and HD are now supported.
And whilst moving items the grid is now a checkerboard.
This is for discussion. Coordinating setting of
vcd_video_systemandosd_displayport_deviceand improving the font (ideally colour to match the HD goggles in HD mode) are clear obvious enhancements.See also betaflight/betaflight#11964.