Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended Bidir Dshot #2980

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Extended Bidir Dshot #2980

merged 1 commit into from
Sep 17, 2022

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis added this to the 10.9.0 milestone Jul 23, 2022
@haslinghuis haslinghuis self-assigned this Jul 23, 2022
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the dshot_extended_telemetry_on_unused_ranges branch from 9ad0806 to 7fd7972 Compare July 23, 2022 22:33
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the dshot_extended_telemetry_on_unused_ranges branch from 7fd7972 to f432ea6 Compare July 24, 2022 00:11
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis mentioned this pull request Jul 24, 2022
Merged
@blckmn
Copy link
Member

blckmn commented Jul 24, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@damosvil damosvil mentioned this pull request Jul 27, 2022
Closed
asizon
asizon approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@asizon asizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting @haslinghuis , wich is the purposse of extended dshot bidir? Provide more information?

@haslinghuis
Copy link
Member Author

@asizon for details see first comment.

@KarateBrot
Copy link
Member

Interesting haslinghuis , wich is the purposse of extended dshot bidir? Provide more information?

ESC telemetry without telemetry cable for BLHeli_S, BLHeli_32, Bluejay and all ESC firmwares who are going to support it.

@blckmn blckmn merged commit 02a1522 into betaflight:master Sep 17, 2022
@haslinghuis haslinghuis deleted the dshot_extended_telemetry_on_unused_ranges branch September 18, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asizon asizon asizon approved these changes

@blckmn blckmn blckmn approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @KarateBrot @asizon