Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move every tab to modules #2464

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Move every tab to modules #2464

merged 2 commits into from
Jul 23, 2022

Conversation

chmelevskij
Copy link
Member

@chmelevskij chmelevskij commented Apr 3, 2021 •
edited
Loading

Move all the tab loading into modules.

Part of #2433

McGiverGim
McGiverGim previously approved these changes Apr 3, 2021
View reviewed changes
@chmelevskij chmelevskij force-pushed the modules/moooooooore-modules branch from 8dc0bb7 to df57eff Compare April 3, 2021 07:26
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@github-actions

This comment has been minimized.

Sign in to view
@chmelevskij
Copy link
Member Author

No bot, go away, I will do this I promise

@github-actions github-actions bot removed the Inactive label May 5, 2021
@chmelevskij chmelevskij force-pushed the modules/moooooooore-modules branch from e81d0bf to 3089b6b Compare June 3, 2021 21:14
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 22 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chmelevskij
Copy link
Member Author

Moved all of the tabs to modules. Will need to verify it works on android and should be OK to merge.

@haslinghuis
Copy link
Member

Everything is working as far I have tested. One problem I found is:

  • enable auto-connect (did not test without)
  • go to cli
  • type dump and wait for the output to be finished
  • select another tab and we get MSP timeouts. After 10 seconds we can reconnect without a problem.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis
Copy link
Member

@chmelevskij can you please rebase?

@github-actions github-actions bot removed the Inactive label Aug 13, 2021
@chmelevskij chmelevskij changed the title move power tab to modules Move every tab to modules Sep 3, 2021
@chmelevskij chmelevskij force-pushed the modules/moooooooore-modules branch 2 times, most recently from b183424 to 1241af3 Compare December 17, 2021 18:16
haslinghuis
haslinghuis previously approved these changes Dec 19, 2021
View reviewed changes
@chmelevskij chmelevskij force-pushed the modules/moooooooore-modules branch 2 times, most recently from f837eee to 1bba88c Compare December 19, 2021 06:33
@haslinghuis haslinghuis added this to the 10.9.0 milestone Jan 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chmelevskij chmelevskij force-pushed the modules/moooooooore-modules branch from f353161 to 9fbbd85 Compare April 14, 2022 20:52
@github-actions

This comment has been minimized.

Sign in to view
@chmelevskij chmelevskij force-pushed the modules/moooooooore-modules branch from 9fbbd85 to 19b7136 Compare April 27, 2022 13:48
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

This comment has been minimized.

Sign in to view
@chmelevskij chmelevskij force-pushed the modules/moooooooore-modules branch from 19b7136 to 5a74094 Compare July 23, 2022 19:18
@chmelevskij chmelevskij marked this pull request as ready for review July 23, 2022 19:18
@github-actions

This comment has been minimized.

Sign in to view
haslinghuis
haslinghuis reviewed Jul 23, 2022
View reviewed changes
src/js/main.js Outdated Show resolved Hide resolved
@chmelevskij @haslinghuis
Update src/js/main.js
852c88d 
Co-authored-by: haslinghuis <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Jul 23, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn blckmn merged commit 8054aa7 into betaflight:master Jul 23, 2022
@McGiverGim McGiverGim mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@blckmn blckmn blckmn approved these changes

@McGiverGim McGiverGim McGiverGim left review comments

Assignees

@chmelevskij chmelevskij

Labels
RN: IMPROVEMENT
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@chmelevskij @haslinghuis @blckmn @McGiverGim @asizon