Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser support #15

Open
tbremer opened this issue Feb 8, 2015 · 5 comments
Open

Browser support #15

tbremer opened this issue Feb 8, 2015 · 5 comments

Comments

@tbremer
Copy link

tbremer commented Feb 8, 2015

I am getting ready to submit a PR, but was wondering what kind of support you wanted this script to have?

You currently don't support IE8, can that be assumed?

What about IE9? 10?

Thanks!
@andrejsm
Copy link

Element.classList is supported starting with IE 10. See MDN classList. Otherwise shim is required.

@bendc
Copy link
Owner

bendc commented Feb 13, 2015

Yup, IE10+ is required.

@patrickcate
Copy link

Browser support should be added to http://uilang.com/

@tbremer
Copy link
Author

tbremer commented Feb 16, 2015

I agree with @patrickcate. Also, updating the script to move away from classList would be an effortless change if you want to broaden support to IE9.

I can make a PR.

@ghost
Copy link

ghost commented Mar 10, 2015

Submitted a pull request for this #17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bendc @andrejsm @tbremer @patrickcate