Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAP-CLIENT-PS not returning validation issues #230

Open
ankitShogun opened this issue Sep 15, 2024 · 3 comments · Fixed by #231
Open

BAP-CLIENT-PS not returning validation issues #230

ankitShogun opened this issue Sep 15, 2024 · 3 comments · Fixed by #231
Assignees
@em-abee
Labels
bug Something isn't working

Comments

@ankitShogun
Copy link
Contributor

ankitShogun commented Sep 15, 2024 •
edited
Loading

A problem I found while debugging this. Request was going through even though exception was being raised on protocol server. This behaviour is acceptable for bpp-client but not for bap-client. Hence debugged and fixed this
@ankitShogun ankitShogun self-assigned this Sep 15, 2024
@ankitShogun ankitShogun linked a pull request Sep 15, 2024 that will close this issue
raising and sending exception back in case of bap client #231
Merged
@emmayank
Copy link

emmayank commented Sep 17, 2024 •
edited
Loading

Review Completed

@ankitShogun please get this PR merged - #231 after getting it reviewed by @em-abee

@em-abee em-abee assigned em-abee and unassigned ankitShogun Oct 3, 2024
@em-abee
Copy link
Contributor

em-abee commented Oct 9, 2024

PR Merged: #231

@em-abee
Copy link
Contributor

em-abee commented Oct 14, 2024

#231

@em-abee em-abee added the bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@em-abee em-abee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

raising and sending exception back in case of bap client beckn/protocol-server
3 participants
@em-abee @emmayank @ankitShogun