You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we use a library called express-openapi-validator for validating requests against the core or layer 2 config. The version of the library we use works upto OpenAPI v 3.0. This version of OpenAPI and corresponding json-schema bound to it are over five years old. There have been significant progress in json-schema, particularly with conditional(if then else) support. These constructs help in writing layer 2 configuration rules.
So we want to now support OpenAPI 3.1 in the protocol server. However the express-openapi-validator library does not still support OpenAPI 3.1. It seems like its very close to releasing support. We have two approaches that we can adopt.
I prefer the former, but it might be a good idea to also try one implementation with latter (We can compare performance of the two and see if the latter is better performant - the field has been complaining that the former is slow)
As part of this ticket, try both the approaches.
For test cases
Ensure all our sandbox specs and samples pass
Write new conditional rules using if-then-else run both positive and negative test cases and log the outputs.
Do some simple performance measures and log the metrics.
The text was updated successfully, but these errors were encountered:
Currently we use a library called express-openapi-validator for validating requests against the core or layer 2 config. The version of the library we use works upto OpenAPI v 3.0. This version of OpenAPI and corresponding json-schema bound to it are over five years old. There have been significant progress in json-schema, particularly with conditional(if then else) support. These constructs help in writing layer 2 configuration rules.
So we want to now support OpenAPI 3.1 in the protocol server. However the express-openapi-validator library does not still support OpenAPI 3.1. It seems like its very close to releasing support. We have two approaches that we can adopt.
I prefer the former, but it might be a good idea to also try one implementation with latter (We can compare performance of the two and see if the latter is better performant - the field has been complaining that the former is slow)
As part of this ticket, try both the approaches.
For test cases
The text was updated successfully, but these errors were encountered: