Rewrite custom require hook & source map tests #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\o/ this is looking great, and is very much appreciated. let me know when you need a thorough review. |
Use a spy to verify custom require hooks are wrapped correctly. Remove the more complicated test using babel-register and clean up dependencies. Stop sharing an nyc instance between the wrap tests.
Use source-map-fixtures to get a fixture file with an inline source map. Add a script to generate a coverage report for this specific fixture. Rewrite tests to use the fixture, without (too much) hardcoding of values. This will make it easier to upgrade the fixture in the future, as well as regenerate the coverage report.
novemberborn
force-pushed
the
rewrite-source-map-tests
branch
from
d3e008f to
f410b7c
Compare
novemberborn
changed the title
|
@bcoe I'm finished with this now, thanks. |
| // Write the coverage file so reports can be loaded. | ||
| nyc.writeCoverageFile() | ||
|
|
||
| var reports = _.values(nyc._loadReports()[0]) |
There was a problem hiding this comment.
this is a great approach for generating the fixtures, and I love the module source-map-fixtures.
|
The tests run way faster without the babel step, this is great. |
bcoe
added a commit
that referenced
this pull request
Dec 6, 2015
Rewrite custom require hook & source map tests
bcoe
pushed a commit
that referenced
this pull request
Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the source map tests so I can add the test coverage required in #66. This necessitated replacing the Babel test with a better one for generic custom require hooks.
This uses a new npm package named source-map-fixtures. It provides a few source files with different source map variants, making it easier to generate fixtures. I'm planning on updating the source map tests in AVA as well.
I've solved the problem of generating coverage reports for testing by adding a
_generateCoveragescript intest/fixtures. It generates a report for the source map fixtures.And finally I've excluded the two tests from the coverage report. Seemed silly to get missing test coverage for the tests…