-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag --incompatible_config_setting_private_default_visibility will break rules_python in Bazel 7.0 #1237
Comments
Hi @chrislovecnm, Could you please look in to this issue.Thanks! |
#1283 is the only place that I see problems with that flag. Please let me know if that upgrade fixes the problem. |
@sgowroji can we close this issue? |
I'm closing; I believe this is fixed. |
But we are still seeing few errors https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1608#0189d2b2-f127-4378-a10b-6a39bd60911e
|
This is in rules_go let me make sure that we have the latest version |
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?" |
Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_go. Please migrate to fix this and unblock the flip of this flag.
---> Note that this was not an issue until build #1349 and has been failing from #1351 onwards.
The flag is documented here: bazelbuild/bazel#12933.
Please check the following CI builds for build and test results:
Linux (OpenJDK 17, gcc 10.2.1)
MAC OS (OpenJDK 11, Xcode)
Ubuntu 20.04 LTS (OpenJDK 11, gcc 9.4.0)
Windows (OpenJDK 11, VS2019)
Ubuntu 20.04 LTS (OpenJDK 11, gcc 9.4.0)
Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.
The text was updated successfully, but these errors were encountered: