Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MODULE.bazel to rules proto #147

Merged
merged 19 commits into from
Sep 22, 2022
Merged

Add MODULE.bazel to rules proto #147

merged 19 commits into from
Sep 22, 2022

Conversation

comius
Copy link
Collaborator

@comius comius commented Sep 20, 2022 •
edited
Loading

This supports using rules_proto as a bzlmod dependency.

@comius comius requested a review from meteorcloudy September 20, 2022 10:51
@comius comius requested a review from lberki as a code owner September 20, 2022 10:52
lberki
lberki previously approved these changes Sep 20, 2022
View reviewed changes
@comius
Copy link
Collaborator Author

comius commented Sep 20, 2022

@meteorcloudy interesting, I don't get the error running locally. Is there another workaround for local_cc_config?

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/bazel_tools/tools/cpp/BUILD:58:19: every rule of type cc_toolchain_alias implicitly depends upon the target '@[unknown repo 'rules_cc.0.0.1.cc_configure.local_config_cc' requested from @]//:toolchain', but this target could not be found because of: no such package '@[unknown repo 'rules_cc.0.0.1.cc_configure.local_config_cc' requested from @]//': The repository '@[unknown repo 'rules_cc.0.0.1.cc_configure.local_config_cc' requested from @]' could not be resolved: Repository '@rules_cc.0.0.1.cc_configure.local_config_cc' is not visible from repository '@'

meteorcloudy
meteorcloudy reviewed Sep 20, 2022
View reviewed changes
.bazelrc Outdated Show resolved Hide resolved
meteorcloudy
meteorcloudy requested changes Sep 20, 2022
View reviewed changes
WORKSPACE.bzlmod Outdated Show resolved Hide resolved
.bcr/presubmit.yml Outdated Show resolved Hide resolved
meteorcloudy
meteorcloudy reviewed Sep 20, 2022
View reviewed changes
MODULE.bazel Outdated Show resolved Hide resolved
@comius comius requested a review from meteorcloudy September 20, 2022 15:21
@comius comius changed the title Bzlmod rules proto Add MODULE.bazel to rules proto Sep 21, 2022
meteorcloudy
meteorcloudy requested changes Sep 21, 2022
View reviewed changes
MODULE.bazel Outdated Show resolved Hide resolved
meteorcloudy
meteorcloudy reviewed Sep 21, 2022
View reviewed changes
.bazelrc Outdated Show resolved Hide resolved
meteorcloudy
meteorcloudy reviewed Sep 21, 2022
View reviewed changes
.bcr/presubmit.yml Outdated Show resolved Hide resolved
@comius comius self-assigned this Sep 21, 2022
meteorcloudy
meteorcloudy approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!!

@comius comius added the ready to pull Required label for automatic import to Google label Sep 21, 2022
@kotlaja kotlaja merged commit 29f9c37 into bazelbuild:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@lberki lberki lberki left review comments

Assignees

@comius comius

Labels
ready to pull Required label for automatic import to Google
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@comius @lberki @meteorcloudy @kotlaja