Update protobuf to 3.20.0 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thii
force-pushed
the
update-protobuf-to-3.20.0-rc1-to-get-prebuit-protoc-for-m1
branch
from
e90450c to
6b168d2
Compare
|
I don't think we should be updating precompiled protobuf to rc versions. |
|
I'll update this when 3.20 is released. |
|
3.20 was released. |
Also add prebuit protoc binaries for Apple silicon.
thii
force-pushed
the
update-protobuf-to-3.20.0-rc1-to-get-prebuit-protoc-for-m1
branch
from
6b168d2 to
6f02e98
Compare
thii
changed the title
|
Updated! |
comius
reviewed
Apr 5, 2022
comius
approved these changes
Apr 5, 2022
comius
reviewed
Apr 5, 2022
proto/private/dependencies.bzl
Outdated
| "sha256": "0019dfc4b32d63c1392aa264aed2253c1e0c2fb09216f8e2cc269bbfb8bb49b5", | ||
| "urls": [ | ||
| "https://mirror.bazel.build/github.com/protocolbuffers/protobuf/releases/download/v3.20.0/protoc-3.20.0-osx-aarch64.zip", | ||
| "https://github.com/protocolbuffers/protobuf/releases/download/v3.20.0/protoc-3.20.0-osx-aarch64.zip", |
There was a problem hiding this comment.
It seems there's an underscore missing:
https://github.com/protocolbuffers/protobuf/releases/download/v3.20.0/protoc-3.20.0-osx-aarch_64.zip
There was a problem hiding this comment.
And checksum is also different.
|
I mirrored the binaries. |
comius
approved these changes
Apr 5, 2022
thii
deleted the
update-protobuf-to-3.20.0-rc1-to-get-prebuit-protoc-for-m1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add prebuilt protoc binaries for Apple silicon.