Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to 1.5.0-alpha2 throws a jdeps error #440

Closed
tandel-pratik opened this issue Jan 5, 2021 · 6 comments · Fixed by #457
Closed

Upgrading to 1.5.0-alpha2 throws a jdeps error #440

tandel-pratik opened this issue Jan 5, 2021 · 6 comments · Fixed by #457

Comments

@tandel-pratik
Copy link

This is the error from sandbox after upgrading to 1.5.0-alpha-2

Cannot locate ECD record in singlejar_local: src/tools/singlejar/input_jar.cc:52: Cannot locate ECD record in bazel-out/darwin-fastbuild/bin/redacted/application.jdeps

@restingbull
Copy link
Collaborator

Does this happen in alpha-3?

@Bencodes
Copy link
Collaborator

We just encountered something similar when testing against alpha3. It looks like if there aren't Kotlin sources in a Kotlin target, a jdep output isn't being generated.

@restingbull
Copy link
Collaborator

@jongerrish?

@jongerrish
Copy link
Contributor

I'll take a look this weekend. @pratik-brex do you have more log info / repro case you can share?

What do you have for your tool chain configuration? Are you enabling experimental_use_abi_jars?

define_kt_toolchain(
    experimental_use_abi_jars = True,
   ...
)

@jeffzoch
Copy link
Contributor

@jongerrish confirm ran into the same issue. We dont use any flags on the toolchain configuration - all defaults and we hit this. No jdeps generated if kotlin sources didnt exist. Adding an empty kotlin class fixed it

@jongerrish
Copy link
Contributor

@jeffzoch - awesome, thanks, sounds like its easy to repro. I'll get a fix in on Sunday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants