-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.24 - March 2019 #6968
Comments
Looks like we have a good baseline for the release in 235e76b. Test run is here: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/831. @meteorcloudy has investigated the two failing projects and they are not release-related. |
@oquenchil 235e76b won't contain your flip of --incompatible_disable_legacy_cc_provider |
The bazel-at-head-plus-downstream tests that include the flag flip for |
@katre Yes, @oquenchil and I just agreed to rollback the flag flip |
Creating rc1:
Tests are running now. |
Release is blocked by #7605: I cannot actually get the release binaries to build. |
@katre Thanks for adding I'm adding the migration labels back for 0.22 and 0.23 |
Thank you @meteorcloudy! |
@meteorcloudy My mistake. We should update the docs at https://github.com/bazelbuild/continuous-integration/blob/master/docs/release-playbook.md and clarify that (I think I see where I went wrong, so expect a PR from me today). |
Creating rc2:
|
@hlopko fedora 30 is soon to release, and the current "rawhide" will be fedora 31 about 6 months later. I bet there will be a fix before then |
I'll defer to @buchgr on that, but we have been broken since 0.22 with this particular issue (0.23 introduced the break), are still broken on 0.24, won't be fixed until 0.25 without intervention, and have only had a chance to properly diagnose it now (we were late to adopt 0.23 as well). |
Makes sense for a patch release. I want to wait for the result on #7874 before I cut it, however. |
Oh wait gcc-9 is not yet released :) Ok I say #7874 doesn't warrant a patch release. |
On 29/03/19 03:50 -0700, Marcel Hlopko wrote:
Oh wait gcc-9 is not yet released :) Ok I say [1]#7874 doesn't warrant
a patch release.
yeah. Fedora Rawhide, is literally that. It's meant as an early canary.
:-)
|
I tried to create 0.24.1rc1:
However, I cannot merge this cherry-pick: the code has changed too far in between and I have no idea what should actually be fixed. @werkt and @buchgr Please give me directions (or, better yet, a commit I can apply to 0.24.0) on how to resolve this. Or wait for the 0.25.0 RC to be delivered early next week. |
Working one up based on |
https://github.com/werkt/bazel/tree/retry-exception-fix-0.24 contains a single commit that addresses the issue and applies to the base commit of 0.24 |
Okay, second attempt at 0.24.1rc1:
Waiting on tests and binaries now. |
0.24.1rc1 is now out: https://releases.bazel.build/0.24.1/rc1/index.html |
Tested, this correctly generates an error that would result in a fallback, excellent! |
This release candidate looks acceptable from my end, is there any update on this? |
I am releasing it today (two business days have passed with no new release blockers). |
0.24.1 is now released (https://github.com/bazelbuild/bazel/releases/tag/0.24.1). @petemounce, @vbatts, and @excitoon: can you update the packages you each maintain? Thanks! |
fedora and centos build:
https://copr.fedorainfracloud.org/coprs/build/876626
|
Pushed. |
Bazel crash immediately with error:
On 0.23.1 works fine. |
What version of glibcxx are you using? @hlopko, is this something that is easy to fix? |
Oh ignore me, I misuderstood the issue. |
Hi @menny - is this still an issue? Can you repro with a clean install of Ubuntu 14.04 (docker will be fine)? Would you mind creating a new issue and pinging me there so we can investigate properly? Thanks! |
@hlopko, It's still an issue on some of our CI pools (the ones that have ubuntu 14). |
I am closing this issue since 0.24.1 is fully released. Once the followup issue about GLIBCXX_3.4.21 is triaged and we determine if a further patch to 0.24 is required, I will re-open. |
@hlopko I've decided to upgrade the old CI machine to Ubuntu 18. |
Target RC date: March 1st
The text was updated successfully, but these errors were encountered: