Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java compilation doesn't include cpu in output paths #6527

Closed
gregestren opened this issue Oct 25, 2018 · 2 comments
Closed

Java compilation doesn't include cpu in output paths #6527

gregestren opened this issue Oct 25, 2018 · 2 comments
Assignees
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Configurability platforms, toolchains, cquery, select(), config transitions

Comments

@gregestren
Copy link
Contributor

Tracking issue on Bazel Configurability Roadmap

Goal:

  • Changing --cpu shouldn't re-compile Java compilations, which don't care about CPU.

This is a specialization of #6526. Currently deprioritized in favor of that issue, which technically solves this one.

I did some research a while back about what it would take to solve just this issue (can we do it faster than the general one?). The story is complicated. Can elaborate further on request.

@gregestren gregestren added P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Configurability platforms, toolchains, cquery, select(), config transitions labels Oct 25, 2018
@gregestren gregestren self-assigned this Oct 25, 2018
@gregestren
Copy link
Contributor Author

2018 EOY update:

This feature is on hold.

This is a specialization of #6526. Initial research suggests that a solution to this feature is complex enough that it's better to focus energies on the broader problem.

I've been prototyping an approach for #6526 that builds genrules and simple cc_* rules successfully in a way that would automatically solve this issue too. Next steps for that are to try building a java_binary, which will be especially interesting for this issue, and sharing more openly the design proposal and its consequences.

@gregestren
Copy link
Contributor Author

This is a dupe of #8339, which is now the more relevant bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

No branches or pull requests

1 participant