Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration transitions in external dependencies don't work? #10118

Closed
deeglaze opened this issue Oct 28, 2019 · 2 comments
Closed

Configuration transitions in external dependencies don't work? #10118

deeglaze opened this issue Oct 28, 2019 · 2 comments
Assignees
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Configurability platforms, toolchains, cquery, select(), config transitions type: bug

Comments

@deeglaze
Copy link
Contributor

My project defines a few transition rules to switch from building a host application to building a binary that works on Intel SGX. It doesn't appear that any clients of my project can use these rules though due to how whitelist label resolution works.

I wrote up a repro here https://github.com/deeglaze/repro/raw/master/external_transition.tar.gz

bazel run :qux_setting --experimental_starlark_config_transitions
@aiuto aiuto added team-Configurability platforms, toolchains, cquery, select(), config transitions untriaged labels Oct 28, 2019
@katre katre added P1 I'll work on this now. (Assignee required) type: bug and removed untriaged labels Nov 8, 2019
@gregestren gregestren added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P1 I'll work on this now. (Assignee required) labels May 11, 2020
@gregestren
Copy link
Contributor

P1 issue review: marking this as a P3 not because it's not important, but because it's an example of #11128. That's the main tracking bug, which is prioritized for this quarter.

Keeping this bug open to verify fixes against this specific example.

@gregestren
Copy link
Contributor

On second though, let's consolidate these bugs into #11128.

When that one is fixed, it if doesn't address this we can re-open this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Configurability platforms, toolchains, cquery, select(), config transitions type: bug
Projects
None yet
Development

No branches or pull requests

4 participants