From 38c586f9eae8df304c8b30d8550b8f1fe9994245 Mon Sep 17 00:00:00 2001 From: cushon Date: Tue, 26 Apr 2022 21:33:17 -0700 Subject: [PATCH] Improve a TODO PiperOrigin-RevId: 444753724 --- .../devtools/build/lib/rules/java/JavaCompileAction.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompileAction.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompileAction.java index 94bee4b6a09f2d..725ea563eac527 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompileAction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompileAction.java @@ -114,8 +114,10 @@ public final class JavaCompileAction extends AbstractAction implements CommandAc enum CompilationType { JAVAC("Javac"), - // TODO(cushon): rename the mnemonic to 'Turbine' after javac-turbine is turned down (and after - // collecting data on the perform impact of the turndown) + // 'javac turbine' has been replaced by just 'turbine', but the mnemonic is unchanged for + // continuity in the blaze performance logs, and to distinguish direct classpath actions + // which use the 'Turbine' mnemonic. + // TODO(b/230333695): consider renaming to a more descriptive name TURBINE("JavacTurbine"); final String mnemonic;