Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map screen lacks required OSM attribution (F-Droid build) #620

Closed
gdt opened this issue Apr 7, 2023 · 3 comments
Closed

Map screen lacks required OSM attribution (F-Droid build) #620

gdt opened this issue Apr 7, 2023 · 3 comments
Labels
Milestone

Comments

@gdt
Copy link

gdt commented Apr 7, 2023

Describe the bug
In the F-Droid build, the map tab shows OSM data and lacks the required attribution.

To Reproduce
Steps to reproduce the behavior:

  1. Install from F-Droid main repo
  2. In hamburger menu, select Map

Expected behavior
The OSM map should have attribution per
https://www.openstreetmap.org/copyright

Observed behavior
No attribution, and a fortiori no clickable link to the license.

App, Device and Android version:

GPSTest v3.9.16
CalyxOS based on AOSP 13

** Comment **

It's likely quite clear from source code that attribution isn't attempted, so I'm not going to go into further details proving it is missing unless that' s actually in dispute.

@gdt gdt added the bug label Apr 7, 2023
@gdt
Copy link
Author

gdt commented Apr 7, 2023

@AntoninDelFabbro your comment about attribution is valid in substance, even if coming across as non-collaborative in tone. I myself am an osm editor, and often cranky about the license, but I reserve serious crankiness for people attempting to get something for themselves, vs people contributing to the free software ecosystem.

Perhaps you know how to fix, and could prepare a PR?

@barbeau barbeau added this to the v4.0 milestone Apr 7, 2023
@barbeau
Copy link
Owner

barbeau commented Apr 7, 2023

@gdt @AntoninDelFabbro Thanks for flagging this, it fell off my radar and got mixed in with the issue of supporting local OSM tiles (#531). I'll add the license attribution in the next release.

@AntoninDelFabbro
Copy link

You're welcome & no worries! Thanks to you for this awesome (and FOSS) app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants