-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Segment events #1669 #1672
Add support for Segment events #1669 #1672
Conversation
@jwalsh-famkit is attempting to deploy a commit to the Typebot Team on Vercel. A member of the Team first needs to authorize it. |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to be merged
Thanks so much for this. I'm currently off and will be able to review it on 13th of August |
No worries, enjoy your time off! |
Thanks for this ❤️ just some minor suggestions for you |
@baptisteArno updates made, ready for merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you review all the actions and make sure that:
- Helper text is only applied when it helps the user finding the information. If you want to provide a longer description of the field, use
moreInfoTooltip
instead. But generally the fields are self explanatory. - Add
await analytics.closeAndFlush()
at the end of each run function to make sure all events are saved - Reflect the name found in the Segment spec (i.e. https://segment.com/docs/connections/spec/track/). Typebot should not rename anything to avoid confusion. So for example you'd have to rename "Event name" to "Name".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, can you remove all the helperText as well? I find that most of them are just redundant, they don't provide help.
Yes, removed most of them, thanks. I left the one in Alias because I think it's helpful to distinguish between the two IDs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, I get it now, thanks!
@baptisteArno thank you for all the help. This is my first time contributing to an OS project, it's a fun learning! Can you let me know if there are any other changes needed, please? Thank you! |
Looks good to me 🔥 |
Thank you so much for this. Will announce this publicly on Discord and Twitter soon :) |
Happy to help, love Typebot and would love to help grow it further. thanks for your patience on this! |
Added support for Twilio Segment
New Segment Block added to Forge. Includes the following:
Tested integration with Segment, verified working. Uses Segment's NodeJS analytics library to support non-browser based platforms, such as WhatsApp