Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart/thanos] Releasing thanos bucket web 0.9.0 fails for change in flag name #984

Closed
jecnua opened this issue Dec 4, 2019 · 2 comments

Comments

@jecnua
Copy link

jecnua commented Dec 4, 2019

Describe the bug

The new thanos version (0.9.0) changes the flag in the bucket component (thanos bucket web) from --listen to --http-address. Trying to release the new version with the latest thanos chart will result in the pod failing with this error:

Error parsing commandline arguments: unknown long flag '--listen'
thanos: error: unknown long flag '--listen'

Steps to reproduce the issue:
Release thanos 0.9.0 web component with the latest helm chart here.

Expected behavior
Pod should be running.

Additional context

You can test the flags here:
docker run -it --name test --rm --entrypoint thanos quay.io/thanos/thanos:v0.8.1 bucket web --help
and
docker run -it --name test --rm --entrypoint thanos quay.io/thanos/thanos:v0.9.0 bucket web --help

@jecnua jecnua changed the title Releasing thanos bucket web 0.9.0 fails for change in flag name [chart/thanos] Releasing thanos bucket web 0.9.0 fails for change in flag name Dec 4, 2019
@MyMirelHub
Copy link

MyMirelHub commented Dec 18, 2019

I had the same problem. The Thanos team have removed the --listen flag in this PR..

@jecnua
Copy link
Author

jecnua commented Jan 15, 2020

Looks like was fixed here e5e72de 9 days ago. I found it by chance however while checking what to change after fork. -.- @MyMirelHub in case you still need this too should be there in the last version.

@jecnua jecnua closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants