From 32636e186064ebd0ba3fc3169a6a74cbb82124dd Mon Sep 17 00:00:00 2001
From: muxator <antonio.muci@bancaditalia.it>
Date: Tue, 10 Sep 2024 17:41:24 +0200
Subject: [PATCH] tests: fix PytestRemovedIn8Warning ("support for nose tests
 is deprecated and will be removed in a future release")

Before this change, the test log contained 37 entries like this:
    PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.

After this change, on my machine the test log shrinks from 1672 to 1405 lines
(16% less).

At some point in time, we will migrate to Pytest 8.x, and this would be an
hindrance.

A reference for the fix can be found at:
    https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose

Affected tests were found with:
    rg "def (setup|teardown)\(" tests
---
 tests/test_calibrator.py                            | 2 +-
 tests/test_losses/test_base.py                      | 2 +-
 tests/test_plot/base.py                             | 2 +-
 tests/test_plot/test_plot_descriptive_statistics.py | 2 +-
 tests/test_plot/test_plot_results.py                | 4 ++--
 tests/test_samplers/test_base.py                    | 2 +-
 tests/test_samplers/test_gaussian_process.py        | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/test_calibrator.py b/tests/test_calibrator.py
index 4abec038..fd8d21f7 100644
--- a/tests/test_calibrator.py
+++ b/tests/test_calibrator.py
@@ -119,7 +119,7 @@ class TestCalibrate:
         ],
     )
 
-    def setup(self) -> None:
+    def setup_method(self) -> None:
         """Set up the tests."""
         self.true_params = np.array([0.50, 0.50])
         self.bounds = [
diff --git a/tests/test_losses/test_base.py b/tests/test_losses/test_base.py
index 9b82c445..16389b0f 100644
--- a/tests/test_losses/test_base.py
+++ b/tests/test_losses/test_base.py
@@ -67,7 +67,7 @@ def compute_loss_1d(
     sim_data: NDArray[np.float64]
     real_data: NDArray[np.float64]
 
-    def setup(self) -> None:
+    def setup_method(self) -> None:
         """Set up the tests."""
         self.loss = TestComputeLoss.MyCustomLoss(
             self.loss_constant,
diff --git a/tests/test_plot/base.py b/tests/test_plot/base.py
index 57203290..1a9218d9 100644
--- a/tests/test_plot/base.py
+++ b/tests/test_plot/base.py
@@ -69,6 +69,6 @@ class BasePlotResultsTest(BasePlotTest):
     saving_folder: Path
 
     @classmethod
-    def setup(cls) -> None:
+    def setup_method(cls) -> None:
         """Set up the test."""
         cls.args = [cls.saving_folder, *cls.args]
diff --git a/tests/test_plot/test_plot_descriptive_statistics.py b/tests/test_plot/test_plot_descriptive_statistics.py
index 2a0cb857..0716fb40 100644
--- a/tests/test_plot/test_plot_descriptive_statistics.py
+++ b/tests/test_plot/test_plot_descriptive_statistics.py
@@ -38,7 +38,7 @@ class TestTsStats(BasePlotTest):
     args: Sequence[Any] = ()
     expected_image = PLOT_DIR / "ts_stats-expected.png"
 
-    def setup(self) -> None:
+    def setup_method(self) -> None:
         """Set up the test."""
         rng = np.random.default_rng(42)
         data = rng.random(100)
diff --git a/tests/test_plot/test_plot_results.py b/tests/test_plot/test_plot_results.py
index 5f802b9a..c50e6579 100644
--- a/tests/test_plot/test_plot_results.py
+++ b/tests/test_plot/test_plot_results.py
@@ -83,7 +83,7 @@ def test_run_by_method_num(self, method_num: int) -> None:
         self.args = [self.saving_folder, method_num]
         super().run()
 
-    def teardown(self) -> None:
+    def teardown_method(self) -> None:
         """Tear down the test."""
         # restore default attributes
         delattr(self, "expected_image")
@@ -113,7 +113,7 @@ def test_run_by_batch_num(self, batch_num: int) -> None:
         self.args = [self.saving_folder, list(range(batch_num))]
         super().run()
 
-    def teardown(self) -> None:
+    def teardown_method(self) -> None:
         """Tear down the test."""
         # restore default attributes
         delattr(self, "expected_image")
diff --git a/tests/test_samplers/test_base.py b/tests/test_samplers/test_base.py
index 6c76afcd..e70274df 100644
--- a/tests/test_samplers/test_base.py
+++ b/tests/test_samplers/test_base.py
@@ -55,7 +55,7 @@ def sample_batch(
             """Sample a batch of parameters."""
             return self.random_generator.random(size=(batch_size, search_space.dims))
 
-    def setup(self) -> None:
+    def setup_method(self) -> None:
         """Set up the tests."""
         self.bounds = [[0.10, 0.10, 0.10], [1.00, 1.00, 1.00]]
         self.bounds_step = [0.01, 0.01, 0.01]
diff --git a/tests/test_samplers/test_gaussian_process.py b/tests/test_samplers/test_gaussian_process.py
index 83471a76..a69101c6 100644
--- a/tests/test_samplers/test_gaussian_process.py
+++ b/tests/test_samplers/test_gaussian_process.py
@@ -29,7 +29,7 @@
 class TestGaussianProcess2D:
     """Test GaussianProcess sampling."""
 
-    def setup(self) -> None:
+    def setup_method(self) -> None:
         """Set up the test."""
         self.xys, self.losses = self._construct_fake_grid(seed=0)