Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rng to the model and use it instead of using seed! #25

Open
Tortar opened this issue Oct 31, 2024 · 1 comment
Open

Add a rng to the model and use it instead of using seed! #25

Tortar opened this issue Oct 31, 2024 · 1 comment

Comments

@Tortar
Copy link
Collaborator

Tortar commented Oct 31, 2024

Using a rng instead of using seed! and store it in the model is generally recommended (this is the approach we use in Agents.jl) so I will update the model to this new form if there are no objections

@Devetak
Copy link
Collaborator

Devetak commented Nov 2, 2024

Hey. I think I have a bit of an abjection. The idea of the model is that the source code can be also modified. For many applications the Shock is not enough (like for example the INET model changing the sampling), so it's better if the code is as simple as possible to allow for this without too much effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants