Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parser.md #1921

Merged
merged 2 commits into from
Dec 19, 2018
Merged

Update parser.md #1921

merged 2 commits into from
Dec 19, 2018

Conversation

chenxsan
Copy link
Contributor

Thought it's a typo there.

@babel-bot
Copy link
Contributor

babel-bot commented Dec 19, 2018

Deploy preview for babel ready!

Built with commit b9843bd

https://deploy-preview-1921--babel.netlify.com

@nicolo-ribaudo
Copy link
Member

Is it possible to make it work both in markdown and on the website? Maybe by using <code> instead of backticks?

@chenxsan
Copy link
Contributor Author

@nicolo-ribaudo Maybe escape | with a \?

It looks fine in my test.

Code:

| Name | Code Example |
|------|--------------|
| `pipelineOperator` ([proposal](https://github.com/babel/proposals/issues/29)) | `a \|> b` |
| `throwExpressions` ([proposal](https://github.com/babel/proposals/issues/23)) | `() => throw new Error("")` |

Rendered:

Name Code Example
pipelineOperator (proposal) a |> b
throwExpressions (proposal) () => throw new Error("")

@nicolo-ribaudo
Copy link
Member

I still see the HTML entity in the site preview 🤔

@chenxsan
Copy link
Contributor Author

@nicolo-ribaudo Tried <code></code>, looks fine now:

image

Not sure what's going on with the website/versioned_docs/version-7.1.0/parser.md file, seems it's auto generated when I commit.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be removed. Thank you!

@xtuc xtuc added the docs label Dec 19, 2018
@xtuc xtuc merged commit 029853c into babel:master Dec 19, 2018
@chenxsan chenxsan deleted the patch-1 branch December 19, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants