glscopeclient: Check WIXPATH before creating MSI installer #388
Conversation
|
The CI build failed. Do you need to install additional software in the CI environment perhaps? (see the .github directory for the scripts) |
|
Done. @umarcor |
| -DCMAKE_INSTALL_PREFIX="${MINGW_PREFIX}" \ | ||
| -DBUILD_TESTING=OFF \ | ||
| ../ | ||
| cmake --build . | ||
|
|
||
| ${MINGW_PREFIX}/bin/cmake.exe --build ./ |
There was a problem hiding this comment.
cmake --build ./ should work, isn't it?
There was a problem hiding this comment.
Yes, previous command works. The new one is just to play safely.
| } | ||
|
|
||
| package() { | ||
| cd "${srcdir}"/../../build | ||
| make DESTDIR="${pkgdir}" install | ||
| DESTDIR="${pkgdir}" ${MINGW_PREFIX}/bin/cmake.exe --build ./ --target install |
There was a problem hiding this comment.
DESTDIR="${pkgdir}" cmake --build ./ --target install?
There was a problem hiding this comment.
Yes, previous command works. The new one is just to play safely.
src/glscopeclient/CMakeLists.txt
Outdated
| COMMENT "Creating Windows x64 MSI..." | ||
| DEPENDS dist_windows_x64 | ||
| WORKING_DIRECTORY ${CMAKE_BINARY_DIR} | ||
| COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/src/glscopeclient/wix/LICENSE.rtf ${CMAKE_BINARY_DIR} |
There was a problem hiding this comment.
It seems that indentation is not correct in this line.
|
One litte question. Why does the CI compile the program twice? |
It should build once for Linux and once for Windows. If there's multiple builds, then we've got a bug in the scripts. |
|
@azonenberg, on Windows it is built twice:
I guess @Biswa96 is asking why don't we extract the |
|
As you are distributing the ZIP file to users, why not skip the msys2 package build or PKGBUILD entirely? |
|
The MSYS2/PKGBUILD build is executed for Continuous Integration/Testing purposes. That provides "nightly" artifacts for contributors to test enhancements/PRs, before the package is bumped in MSYS2 repositories. |
|
OK, all doubt cleared 😌 |
No description provided.