-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default api gateway stage name to v1 #431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=========================================
+ Coverage 93.6% 93.6% +<.01%
=========================================
Files 18 18
Lines 2861 2863 +2
Branches 375 375
=========================================
+ Hits 2678 2680 +2
Misses 132 132
Partials 51 51
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Capturing offline discussion: Should we change the default to Thoughts? |
I am in favor of something like Making it named |
Ok I'll update the PR to use |
35e4809
to
241ea14
Compare
Pushed an update that changes the stage name to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the use of api out of all the options we have considered. 🚢
There's some confusion about chalice stages and api gateway stages and to make this more clear, I propose changing the default value for api gateway stages to v1. This is a backwards compatible change because this value is pulled from the .chalice/config.json. This is just changing what the default value is that's written to the config file as part of the new-project command.
Based on PR discussion.
241ea14
to
263cfbb
Compare
I'm confused by this. I used to have a chalice project with some common code that supported 2 different apis (and code would check where it is being called from): foo.mycompany.com/dev I could deploy to different stages using chalice deploy dev or chalice deploy prod etc and it would create endpoints like you expect. Before deploying I had a script that would update chalice config.json to change the app_name. But now I only get foo.mycompany.com/api. I tried changing deployed.json which could allow different path but it seems to be ignoring app name and I don't think this is intended way to do it, but --stage doesn't seem to be doing anything. Any suggestion? |
Is there any way in latest version of chalice to handle my use case where I have 2 different APIs that need multiple stages generated from the same source? |
There's some confusion about chalice stages and api gateway stages
and to make this more clear, I propose changing the default value
for api gateway stages to v1.
This is a backwards compatible change because this value is pulled
from the .chalice/config.json. This is just changing what the
default value is that's written to the config file as part of the
new-project command.
Also updated the docs to use
v1
to avoid confusion.