Add generate-pipelines command #277
Conversation
This will create a cfn template for a starter CD pipeline based on your chalice app. I see this expanding over time to allow more granular choices about the initial pipeline, but for now a user will have to modify the generated template before deploying.
jamesls
requested review from
dstufft,
stealthycoin,
JordonPhillips and
kyleknap
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 86.55% 87.13% +0.57%
==========================================
Files 18 19 +1
Lines 1696 1780 +84
Branches 207 208 +1
==========================================
+ Hits 1468 1551 +83
- Misses 175 176 +1
Partials 53 53
Continue to review full report at Codecov.
|
| ] | ||
| } | ||
|
|
||
| CODEPIPELINE_POLICY = { |
There was a problem hiding this comment.
So is this the minimal amount of permissions needed to get codepipeline working? Seems a little weird that there is a good amount of services included in it that don't really need to be like beanstalk and opsworks
There was a problem hiding this comment.
That's from the console setup, yeah.
EDIT: I can also take a pass at paring these down. I'm a little hesitant to change the defaults from the console, but it should be possible.
There was a problem hiding this comment.
Yeah. I am fine keeping it as it. It just pointed it out as it looked weird given you really only used half of those services and normally for IAM policies you keep it as minimal as possible.
|
The process isn't really defined at this point. It will really depend on the types of changes people want made. If anything I would expect more parameterization to happen, i.e github instead of codecommit, more stages, etc. Right now you just have to modify the template manually, but eventually we'd expose CLI options for these. Or at least that's what I had in mind. |
|
@jamesls I guess I am wondering are you following up with documentation on how you can use the |
|
@kyleknap How about this? I can update the PR to add docs for the |
|
@jamesls sounds good to me. |
Note that I also had to add an ignore rule for pydocstyle: D301: Use r""" if any backslashes in a docstring The backslash style is required for click to preserve newlines (http://click.pocoo.org/5/documentation/).
|
Cool added docs. |
This will create a cfn template for a starter CD pipeline
based on your chalice app. I see this expanding over
time to allow more granular choices about the initial pipeline,
but for now a user will have to modify the generated template
before deploying.
NOTE: to test I had to change the
sudo pip install chaliceline to point to a copy that contained the package command. This won't be an issue once the package command is released on pypi.