Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chalice local does not respect CORS config #436

Closed
corespace opened this issue Jul 27, 2017 · 1 comment · Fixed by #444
Closed

chalice local does not respect CORS config #436

corespace opened this issue Jul 27, 2017 · 1 comment · Fixed by #444
Labels
enhancement

Comments

@corespace
Copy link

Not sure if this is expected or not, but it appears that chalice local just ignores my CORS config and returns some defaults: https://github.com/awslabs/chalice/blob/master/chalice/local.py#L197-L208

I would prefer if I could test my CORS config locally. Please let me know if I'm missing something obvious...
@corespace corespace mentioned this issue Jul 28, 2017
Closed
@corespace
Copy link
Author

I've created a pull request with a test that seems to fix this for me. Can you take a look and provide some feedback?

@stealthycoin stealthycoin mentioned this issue Jul 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for local OPTIONS CORS headers aws/chalice
2 participants
@corespace @stealthycoin