Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually provided role not updated on redeployment #339

Closed
mmcdermo opened this issue May 15, 2017 · 1 comment
Closed

Manually provided role not updated on redeployment #339

mmcdermo opened this issue May 15, 2017 · 1 comment
Labels

Comments

@mmcdermo
Copy link

mmcdermo commented May 15, 2017

It would be handy if chalice updated the IAM role for the lambda function whenever it performs an update on the function. To demonstrate that it doesn't currently have this functionality:

If you configure chalice to use a manually provided role in config.json with:

"manage_iam_role":false
"iam_role_arn":"arn:aws:iam::<account-id>:role/<role-name>"

Then

chalice deploy

Then change the role to something else:

"iam_role_arn":"arn:aws:iam::<account-id>:role/<role-2-name>

Then deploy again:

chalice deploy

You'll see that the deployed lambda function still retains the first role. This makes sense, as only environment variables are updated inside awsclient.TypedAWSClient.update_function.

@kyleknap
Copy link
Contributor

kyleknap commented Jun 8, 2017

Closing issue out. It got fixed in this PR: #363. It will be available in the next chalice release.

@kyleknap kyleknap closed this as completed Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants