Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chalice doesn't support dict comps #131

Closed
RogerThomas opened this issue Oct 6, 2016 · 1 comment
Closed

Chalice doesn't support dict comps #131

RogerThomas opened this issue Oct 6, 2016 · 1 comment
Labels
bug

Comments

@RogerThomas
Copy link

Dict comps break chalice deploy with awfull error messagas

e.g. this anywhere in the code will cause chalice deploy to fail

d = {k: v for k, v in [(1, 2), (3, 4)]}

I know dict comp's were only introduced in 2.7, but I thought chalice was 2.7>
@jamesls
Copy link
Member

jamesls commented Oct 10, 2016

Definitely a bug, you should be able to use dict comprehensions in a chalice app. I'll get that updated.

@jamesls jamesls added the bug label Oct 10, 2016
@jamesls jamesls mentioned this issue Oct 13, 2016
Closed
jamesls added a commit to jamesls/chalice that referenced this issue Oct 13, 2016
@jamesls
Don't crash policy gen on dict comp
5869f0d 
For now we skip traversal into a dict comp.
In the future, we should treat this like a function
and traverse into the DictComp node looking for any
client calls, but the behavior until that feature
is implemented is to not crash.

Fixes aws#131.
@jamesls jamesls mentioned this issue Oct 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesls @RogerThomas