Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings(s2n-tls): add kem_group api #4896

Open
4 tasks
jmayclin opened this issue Nov 14, 2024 · 0 comments
Open
4 tasks

bindings(s2n-tls): add kem_group api #4896

jmayclin opened this issue Nov 14, 2024 · 0 comments

Comments

@jmayclin
Copy link
Contributor

Problem:

The kem_group api is not available in the rust bindings.

s2n-tls/api/s2n.h

Lines 3311 to 3317 in 2ba3dda

/**
* Function to get the human readable KEM group name for the connection.
*
* @param conn A pointer to the s2n connection
* @returns A human readable string for the KEM group. If the connection is < TLS1.3 or there is no KEM group configured returns "NONE"
*/
S2N_API extern const char *s2n_connection_get_kem_group_name(struct s2n_connection *conn);

Solution:

This should be added to the rust bindings.

Requirements / Acceptance Criteria:

  • the kem_group api should be added to the s2n-tls crate
  • documentation should make the differences between kem_group and kem_name clear.
  • the pq_sanity_check in integration/src/libs.rs should be updated to use the default_pq policy and assert on the negotiated kem group
  • the pq_handshake in integration/src/network/tls_client.rs should be updated to use the default_pq policy and assert on the negotiated kem group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants