Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karpenter version is 1.0.8, but helm still uses 0.37.0? #7372

Closed
timetofaceit opened this issue Nov 13, 2024 · 3 comments
Closed

Karpenter version is 1.0.8, but helm still uses 0.37.0? #7372

timetofaceit opened this issue Nov 13, 2024 · 3 comments
Labels
good-first-issue Good for newcomers triage/needs-owner Indicates that the issue needs an owner to address it

Comments

@timetofaceit
Copy link

timetofaceit commented Nov 13, 2024 •
edited
Loading

Description

Hi! 👋

Just want to ask is this a bug or forgotten update that Karpenter version and helm chart image versions are different?

Link - https://github.com/aws/karpenter-provider-aws/blob/v1.0.8/charts/karpenter/values.yaml#L104
@timetofaceit timetofaceit added bug Something isn't working needs-triage Issues that need to be triaged labels Nov 13, 2024
@rschalo
Copy link
Contributor

rschalo commented Nov 18, 2024

Hi @timetofaceit - looks like this is changed in main: https://github.com/aws/karpenter-provider-aws/blob/main/charts/karpenter/values.yaml#L107. That said, feel free to open a PR for release-v1.0.x: https://github.com/aws/karpenter-provider-aws/blob/release-v1.0.x/charts/karpenter/values.yaml#L104

@rschalo rschalo added good-first-issue Good for newcomers triage/needs-owner Indicates that the issue needs an owner to address it and removed bug Something isn't working needs-triage Issues that need to be triaged labels Nov 18, 2024
@kpjani kpjani mentioned this issue Nov 19, 2024
Closed
3 tasks
@kpjani
Copy link

kpjani commented Nov 19, 2024

Submitted PR to update the version: #7403

@rschalo
Copy link
Contributor

rschalo commented Nov 19, 2024 •
edited
Loading

Thanks - it looks like I missed that there is already an issue tracking this #5415. Closing in favor of that that issue.

@rschalo rschalo closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers triage/needs-owner Indicates that the issue needs an owner to address it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kpjani @rschalo @timetofaceit