Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleJson release broke Chalice release #1304

Closed
subssn21 opened this issue Nov 18, 2019 · 4 comments · Fixed by #1316
Closed

SimpleJson release broke Chalice release #1304

subssn21 opened this issue Nov 18, 2019 · 4 comments · Fixed by #1316
Labels

Comments

@subssn21
Copy link
Contributor

subssn21 commented Nov 18, 2019

I went to run a chalice release of my code this morning and it will deploy but not . run because of a 502 error.

I get this message during deploy:

Creating deployment package.

Could not install dependencies:
simplejson==3.17.0
You will have to build these yourself and vendor them in
the chalice vendor folder.

Your deployment will continue but may not work correctly
if missing dependencies are not present. For more information:
http://chalice.readthedocs.io/en/latest/topics/packaging.html

It ends up that last night a new release of simplejson was released and apparently it breaks the chalice deployment.

Not sure why we need simplejson as there is a built in json, (probably because simplejson is faster)

Also not sure why we are auto using the latest version. We should use specific version and test each new version before using it so this doesn't happen.

The package installs and works fine so I am not sure why it is failing to install during deployment

@subssn21
Copy link
Contributor Author

You can work around this issue by adding

simplejson==3.16.0

to your requirements.txt

@subssn21 subssn21 changed the title SimpleJson release broken Chalice release SimpleJson release broke Chalice release Nov 18, 2019
@KoreyPeters
Copy link

simplejson handles pushing JSON to DynamoDB better than the built in json package. Boto3 keeps throwing back integers as Decimal, which makes the built in json package barf.

@stealthycoin
Copy link
Contributor

Thanks for the report I'll look into it.

@stealthycoin
Copy link
Contributor

Relabled as bug and I have a PR to fix it up. I am surprised this didn't get reported sooner! I guess case 3 (from the commit message) is much less common than I would expect. Thanks for reporting this.

@stealthycoin stealthycoin removed their assignment Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants