Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(credential-providers): collect credential providers in single package #2672

Merged
merged 10 commits into from
Aug 18, 2021
Merged

feat(credential-providers): collect credential providers in single package #2672

merged 10 commits into from
Aug 18, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Aug 13, 2021 •
edited
Loading

Resolves #2393
Resolves #1796

Description

This package also provides fromTemporaryCredentials, which equivalent to ChainableTemporaryCredentials class in v2
Added an all-in-one doc for all the providers: https://github.com/aws/aws-sdk-js-v3/blob/719a49b36eb4bf2837c54cf35edb30292ad032b7/packages/credential-providers/README.md

Testing

Unit test

Additional context

Add any other context about the PR here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP marked this pull request as draft August 13, 2021 17:17
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@cbdcd9c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8462240 differs from pull request most recent head 77841c8. Consider uploading reports for the commit 77841c8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2672   +/-   ##
=======================================
  Coverage        ?   58.93%           
=======================================
  Files           ?      528           
  Lines           ?    28991           
  Branches        ?     7188           
=======================================
  Hits            ?    17085           
  Misses          ?    11906           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdcd9c...77841c8. Read the comment docs.

@AllanZhengYP
feat(credential-providers): collect credential providers in public fa…
17be080 
…cing package
@AllanZhengYP
feat(credential-providers): support temporary credentials provider
b3d48ae 
Equivalent to ChainableTemporaryCredentials class in v2 SDK. The provider
is not re-exported from standalone package or used in the credential-
provider-ini because the roleAssumers function interface in other
packages does not suite the usecase of this provider. In roleAssumer
interface, the master credential is required. It's not true for
fromTemporaryCredentials, where master credentials can be skipped,
in which case the default credential will be used.
@AllanZhengYP
test(credential-providers): add temporary credentials unit tests
c4d708f
@AllanZhengYP
docs: remove inline import to improve docs
248cf7d
@AllanZhengYP AllanZhengYP force-pushed the chainable-credential-provider branch from 88b8231 to f5b33d5 Compare August 17, 2021 16:48
@AllanZhengYP AllanZhengYP force-pushed the chainable-credential-provider branch from f5b33d5 to aacac32 Compare August 18, 2021 07:13
@AllanZhengYP AllanZhengYP changed the title [WIP]feat(credential-providers): collect credential providers in single package. feat(credential-providers): collect credential providers in single package. Aug 18, 2021
@AllanZhengYP AllanZhengYP marked this pull request as ready for review August 18, 2021 17:02
@AllanZhengYP AllanZhengYP changed the title feat(credential-providers): collect credential providers in single package. feat(credential-providers): collect credential providers in single package Aug 18, 2021
@AllanZhengYP AllanZhengYP requested a review from trivikr August 18, 2021 17:09
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 719a49b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trivikr
trivikr reviewed Aug 18, 2021
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
packages/credential-providers/README.md Outdated Show resolved Hide resolved
packages/credential-providers/README.md Outdated Show resolved Hide resolved
packages/credential-providers/README.md Outdated Show resolved Hide resolved
packages/credential-providers/README.md Outdated Show resolved Hide resolved
packages/credential-providers/README.md Outdated Show resolved Hide resolved
packages/credential-providers/README.md Outdated Show resolved Hide resolved
packages/credential-providers/README.md Outdated Show resolved Hide resolved
packages/credential-providers/README.md Outdated Show resolved Hide resolved
packages/credential-providers/README.md Outdated Show resolved Hide resolved
@AllanZhengYP AllanZhengYP force-pushed the chainable-credential-provider branch from 8462240 to 9d0a833 Compare August 18, 2021 22:59
trivikr
trivikr approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UPGRADING.md Outdated Show resolved Hide resolved
@AllanZhengYP @trivikr
docs: fix typos
77841c8 
Co-authored-by: Trivikram Kamat <[email protected]>
@AllanZhengYP AllanZhengYP merged commit 5375c91 into aws:main Aug 18, 2021
@AllanZhengYP AllanZhengYP mentioned this pull request Aug 21, 2021
Merged
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile is not read when defined as assuming role ChainableTemporaryCredentials
4 participants
@AllanZhengYP @codecov-commenter @aws-sdk-js-automation @trivikr