Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change verbosity behavior #10

Closed
mattsb42-aws opened this issue Sep 28, 2017 · 3 comments
Closed

change verbosity behavior #10

mattsb42-aws opened this issue Sep 28, 2017 · 3 comments

Comments

@mattsb42-aws
Copy link
Member

mattsb42-aws commented Sep 28, 2017

The verbosity flag controls how the logger is configured.

Current verbosity behavior is:

  • nothing : no logging
  • -v : WARN (global)
  • -vv : INFO (global)
  • -vvv : DEBUG (global)

After going through various scenarios and using the logging output, I decided a more useful approach would be:

  • nothing : WARNING (aws_encryption_sdk_cli), CRITICAL (root)
  • -v : INFO (aws_encryption_sdk_cli), CRITICAL (root)
  • -vv : DEBUG (aws_encryption_sdk_cli), CRITICAL (root)
  • -vvv : DEBUG (aws_encryption_sdk_cli), INFO (root)
  • -vvvv : DEBUG (aws_encryption_sdk_cli), DEBUG (root)

WARN is always on for safety reasons: we want users to always be aware of WARN events.

@mattsb42-aws
Copy link
Member Author

@juneb
Copy link
Contributor

juneb commented Oct 3, 2017

In this scenario, -v seems to have no effect. It's the same as omitting the parameter. I don't think that's a useful customer experience. If I'm using the default, but not getting enough info, I start by using -v and nothing changes. I recommend that the default (nothing), be errors only.

@mattsb42-aws
Copy link
Member Author

Whoops, I mis-spoke in the issue details. Updated to reflect what the code actually does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants