Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect resource type for hover and resource documentation link #1346

Closed
sliedig opened this issue Feb 7, 2020 · 3 comments
Closed

Incorrect resource type for hover and resource documentation link #1346

sliedig opened this issue Feb 7, 2020 · 3 comments

Comments

@sliedig
Copy link

sliedig commented Feb 7, 2020

cfn-lint version: (cfn-lint --version)
cfn-lint 0.27.4

Description of issue.

In VS Code, if you hover over resources that have the Serverless or Amplify namespace, it gets interpreted as a AmazonMQ resource, and links you to that product documentation e.g.

  • AWS::Serverless::Function
  • AWS::Serverless::Api
  • AWS::Amplify::Branch
  • AWS::Amplify::App

image

@kddejong
Copy link
Contributor

kddejong commented Feb 7, 2020

@sliedig I'll take a look into this. I want to make sure the data itself isn't bad.

That being said we are using another package that provides the yaml capabilities. We just provide the file and settings to configure it. I'm not sure this will be inside our control but I want to make sure we are providing the most accurate data to that language server first.

@PatMyron
Copy link
Contributor

PatMyron commented Feb 8, 2020

@PatMyron
Copy link
Contributor

@sliedig new extension version published to the marketplace fixes documentation links and autocomplete for non-AWS::Serverless resource types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants