Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support download of multiple blocks #1901

Closed
Tracked by #1220
rahulksnv opened this issue Aug 28, 2023 · 0 comments · Fixed by #1911
Closed
Tracked by #1220

Support download of multiple blocks #1901

rahulksnv opened this issue Aug 28, 2023 · 0 comments · Fixed by #1911
Assignees
@rahulksnv
Labels
core Related to core protocol, may affect fundamentals improvement it is already working, but can be better performance Related to performance measurement or improvement

Comments

@rahulksnv
Copy link
Contributor

The current block relay only supports downloading a single block at a time. We found out later that the same block handler path also gets used when nodes are syncing. The syncing takes a long time because of the single block download.

This needs to be changed to send the multiple/full requested blocks in the response, without going through the optimization protocol path.
@rahulksnv rahulksnv added improvement it is already working, but can be better core Related to core protocol, may affect fundamentals performance Related to performance measurement or improvement labels Aug 28, 2023
@rahulksnv rahulksnv self-assigned this Aug 28, 2023
This was referenced Aug 28, 2023
Closed
Closed
@nazar-pc nazar-pc mentioned this issue Aug 30, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulksnv rahulksnv

Labels
core Related to core protocol, may affect fundamentals improvement it is already working, but can be better performance Related to performance measurement or improvement
Projects
None yet
Milestone
No milestone
1 participant
@rahulksnv