Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex Builder and JSON Performance. POJOs and Generics. #21

Open
alvin-reyes opened this issue Oct 29, 2017 · 1 comment
Open

Complex Builder and JSON Performance. POJOs and Generics. #21

alvin-reyes opened this issue Oct 29, 2017 · 1 comment
Assignees

Comments

@alvin-reyes
Copy link
Collaborator

Same notes as @Bodia added. I saw some minor tweaks (e.g. the timeout configs could be moved to Globals or given as parameters) but considering this is WIP we will get there eventually.

On a side note I was thinking that the builders got a little too complicated maybe?
Also it seems to me that we're digging through JSONs a little bit too much and we should rely more on POJOs and maybe generics in the future?

@bohdanbezp
Copy link
Contributor

Yeah, I have a feeling about complex builders as well. It's convenient, but also limits the flexibility to add certain changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants