feat(pagination): add pagination component #302
Conversation
| @@ -0,0 +1,83 @@ | |||
| import { customElement, useView, PLATFORM, bindingMode } from 'aurelia-framework'; | |||
| import { bindable } from 'aurelia-typed-observable-plugin'; | |||
There was a problem hiding this comment.
@EisenbergEffect is it ok to go ahead?
There was a problem hiding this comment.
I would prefer to resolve the design issue with au2 and then bake the same design into au1 core.
There was a problem hiding this comment.
@bigopon What needs to be done to progress this?
There was a problem hiding this comment.
Need to settle on how we would want to API to be for type declaration shortcut:
@bindable({ mode: 'toggle' })
@bindable({ type: 'bool' })
@bindable({ coerce: 'bool' })
@bindable({ set: 'bool' })There was a problem hiding this comment.
I think for now, we can settle first with set api supporting only a setter function, as it's already in v2. For more high level api like type/mode/coerce, we can enhance it later. Does that sound good to start adding it to v1?
There was a problem hiding this comment.
@EisenbergEffect any comment on the above ☝️
# Conflicts: # app/package.json # app/src/components.html # app/webpack.config.js # lerna.json # packages/components/package.json # packages/components/src/index.ts
uses typed plugin as agreed in #299
fixes #300