Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux-button custom type #187

Open
dspublic opened this issue Mar 21, 2019 · 0 comments
Open

ux-button custom type #187

dspublic opened this issue Mar 21, 2019 · 0 comments

Comments

@dspublic
Copy link

dspublic commented Mar 21, 2019

I'm submitting a feature request

  • Library Version:
    0.14.1

  • Current behavior:
    The typeChanged method of UXButton class doesn't allow a custom type value use.
    if (newValue == null || typeClasses.includes("ux-button--" + newValue) === false ) { newValue = 'raised'; }

  • What is the expected behavior?
    I would like this;
    if (newValue == null ) { newValue = 'raised'; }

  • What is the motivation / use case for changing the behavior?
    In this case, we can define a custom button style in css, and use it as type parameter:
    <ux-button type="custom-type"></ux-button>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants