Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all component build to rollup #162

Closed
bigopon opened this issue Apr 3, 2018 · 5 comments
Closed

Switch all component build to rollup #162

bigopon opened this issue Apr 3, 2018 · 5 comments

Comments

@bigopon
Copy link
Member

bigopon commented Apr 3, 2018

With #147 in place, and incoming new way to register global resources via aurelia/framework#858 , it's now possible to distribute every ux package in a single file., and it's more desirable to to do, for build pref, runtime startup perf, size reasons.

Rollup is a good bundler for this, and it will also make the build setup very simple.

Thoughts ? @ZHollingshead @EisenbergEffect

@serifine
Copy link
Contributor

serifine commented Apr 3, 2018

I like the idea of this. Is this one file overall per component or one file per format? (i.e. one for AMD, one for CommonJS, one for system)

@bigopon
Copy link
Member Author

bigopon commented Apr 3, 2018

it will be one file overall per module type (amd, commonjs ...) , like what we did with core.

@serifine
Copy link
Contributor

serifine commented Apr 3, 2018

Alright, I think this will be fine then. We should have the packages and core synced up anyways as far as the build method.

@EisenbergEffect
Copy link
Contributor

@bigopon This can be closed right?

@bigopon
Copy link
Member Author

bigopon commented Apr 14, 2020

Yes, Rollup, while gives a lot of benefits related to distribution, limits the consumption of a component library that distributes custom element (ex: CSS autoprefixing).
Closing this as we went for the middle way.

@bigopon bigopon closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants