Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor debug experience due to broken source maps #503

Closed
suamikim opened this issue Feb 27, 2017 · 8 comments
Closed

Poor debug experience due to broken source maps #503

suamikim opened this issue Feb 27, 2017 · 8 comments
Labels

Comments

@suamikim
Copy link

I'm submitting a bug report

  • Library Version:
    1.0.8

Please tell us about your environment:

  • Operating System:
    Windows 10

  • Node Version:
    6.9.4

  • NPM Version:
    4.1.1

  • Browser:
    Chrome 56 but I guess it's browser independent

  • Language:
    TypeScript 2.1.5

Current behavior:
Breakpoints in Chrome Dev Tools don't show the correct mapped source code. This seems to be mostly the case when debugging 3rd party dependencies which can most of the time be considered as an inconvenience but also happens when debugging application code itself which is more of a show stopper:

debug issues

I've already described the issue in detail on stackoverflow and therefore don't duplicate the reproduction steps etc. here but am happy to do so if required ;)

Also when writing the stackoverflow question I was under the impression, that this only happens for 3rd party scripts but realized later, that this also happens for application code. If necessary I can try to create a simple test application with reproduction steps etc.

This is possibly a consequence of #342 but I believe that it should still be a dedicated issue...

@AStoker
Copy link
Contributor

AStoker commented Feb 27, 2017

I'm not sure (can't recall right now) if we're actually bundling/including source maps for vendor files. It's possible that if a vendor has a source map, that it's being screwed up in the bundle process because it's looking for files that don't exist...
If it's related to the bundling issue, we'd appreciate any help with that.
If you're able to read out the sourcemaps somewhat and maybe find out where it's erroneously pointing to the wrong file, that'd be great. Otherwise, if you could set up a repo that we could pull down and look at, that would be helpful as well.

@EisenbergEffect
Copy link
Contributor

I believe the fix for some of this is coming in the next release. We had some improvements related to source maps.

@suamikim
Copy link
Author

@EisenbergEffect Good to hear! Do you have any idea on when the next release will be published?

@AStoker Actually I'm currently not able to reproduce the mentioned behavior but I'll try to create a repo with reproduction steps as soon as I experience it the next time!

@EisenbergEffect
Copy link
Contributor

Next release very soon. This week, even if it kills me.

@suamikim
Copy link
Author

Haha, good to hear (that it's coming soon, not that it's troublesome...)

@EisenbergEffect
Copy link
Contributor

It's not troublesome. I've just got a bit behind on releases and I'm determined to get that all sorted this week.

@JeroenVinke
Copy link
Collaborator

@suamikim can you confirm whether or not aurelia-cli 0.25.0 fixed this issue? Thanks

@suamikim
Copy link
Author

suamikim commented Mar 5, 2017

Since I can't even reproduce the issues in version 0.24.0 with my current code base I can't reliably confirm that they're fixed with 0.25.0 or later.

Therefore I'm closing this issue and simply reopen it if I'll ever experience them again.

@suamikim suamikim closed this as completed Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants