fix(jest task): Return error when tests fail

Callback always resolved successfully even when test failed Incorrect data was accessed in result data to determine failure Closes #1052
aurelia · Feb 18, 2019 · bfbe072 · bfbe072
1 parent 1455a35
commit bfbe072
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/resources/tasks/jest.js b/lib/resources/tasks/jest.js
@@ -13,9 +13,9 @@ export default (cb) => {
 
   process.env.BABEL_TARGET = 'node';
 
-  jest.runCLI(options, [path.resolve(__dirname, '../../')]).then((result) => {
-    if (result.numFailedTests || result.numFailedTestSuites) {
-      cb(new PluginError('gulp-jest', { message: 'Tests Failed' }));
+  jest.runCLI(options, [path.resolve(__dirname, '../../')]).then(({ results }) => {
+    if (results.numFailedTests || results.numFailedTestSuites) {
+      cb(new PluginError('jest-cli', { message: 'Tests Failed' }));
     } else {
       cb();
     }

diff --git a/lib/resources/tasks/jest.ts b/lib/resources/tasks/jest.ts
@@ -12,9 +12,9 @@ export default (cb) => {
     Object.assign(options, { watch: true});
   }
 
-  jest.runCLI(options, [path.resolve(__dirname, '../../')]).then((result) => {
-    if(result.numFailedTests || result.numFailedTestSuites) {
-      cb(new PluginError('gulp-jest', { message: 'Tests Failed' }));
+  jest.runCLI(options, [path.resolve(__dirname, '../../')]).then(({ results }) => {
+    if (results.numFailedTests || results.numFailedTestSuites) {
+      cb(new PluginError('jest-cli', { message: 'Tests Failed' }));
     } else {
       cb();
     }