Skip to content

Commit

Permalink
fix(release-check): bypass win32 puppeteer error on 0.0.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
3cp committed Jun 20, 2019
1 parent 19f6547 commit bcbe262
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion build/tasks/release-checks/tasks/check-javascript-errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ module.exports = class CheckJavascriptErrors extends Task {
constructor(url) {
super('Check javascript errors');

this.url = url;
// somehow puppeteer/win32 thinks http://0.0.0.0:5000 is an invalid address.
this.url = url.replace('//0.0.0.0', '//localhost');
}

execute() {
Expand Down
3 changes: 2 additions & 1 deletion build/tasks/release-checks/tasks/take-screenshot-of-page.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ module.exports = class TakeScreenShotOfPage extends Task {
constructor(url, path) {
super('Take screenshot of page');

this.url = url;
// somehow puppeteer/win32 thinks http://0.0.0.0:5000 is an invalid address.
this.url = url.replace('//0.0.0.0', '//localhost');
this.path = path;
}

Expand Down

0 comments on commit bcbe262

Please sign in to comment.