fix(bundler): avoid unnecessary rewrite of index.html

closes #1049
aurelia · Feb 16, 2019 · 9faea2f · 9faea2f
1 parent 8e775b7
commit 9faea2f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/build/bundle.js b/lib/build/bundle.js
@@ -457,16 +457,18 @@ exports.Bundle = class {
         return;
       }
 
-      let indexFile = fs.readFileSync(platform.index);
+      const indexFile = fs.readFileSync(platform.index);
       const outputDir = platform.baseUrl || platform.output;
       const configMatcher = Utils.createSrcFileRegex(outputDir, this.moduleId);
       const bundleFileName = this.hash ? Utils.generateHashedPath(this.config.name, this.hash) : this.config.name;
       const bundleLocation = path.posix.join(outputDir, bundleFileName);
       // Replace file name with hashed file name
       if (configMatcher.test(indexFile)) {
-        indexFile = indexFile.replace(configMatcher, 'src="$2' + bundleLocation + '"');
-        await fs.writeFile(platform.index, indexFile);
-        logger.info(`Updated file name for ${this.moduleId} in ${platform.index}`);
+        const newIndexFile = indexFile.replace(configMatcher, 'src="$2' + bundleLocation + '"');
+        if (newIndexFile !== indexFile) {
+          await fs.writeFile(platform.index, newIndexFile);
+          logger.info(`Updated file name for ${bundleFileName} in ${platform.index}`);
+        }
       }
     } catch (error) {
       logger.error(`Couldn't update file name with revision in ${platform.index}`, error);