Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag support for docker images #291

Open
telmich opened this issue Nov 19, 2021 · 3 comments · May be fixed by #292
Open

Add tag support for docker images #291

telmich opened this issue Nov 19, 2021 · 3 comments · May be fixed by #292

Comments

@telmich
Copy link

telmich commented Nov 19, 2021

This is an amazing and easy container, I love it. For k8s setups, it would be great if this container had some more tags / different versions, like:

  • alpine:3.14
  • debian:...

While it is not saying which openssh it is, it is at least clear that it is the openssh that was available in alpine:3.14. This would also make it easier for upgrading in k8s environments, as the :latest tag needs to be pulled every time and cannot be controlled whether this is changed.

I could contribute two small scripts, if they would be merged, like:

  • debian.sh <version> building and creates the images based on debian:version
  • alpine.sh ... same same

Does that make sense?
telmich pushed a commit to ungleich/sftp that referenced this issue Nov 19, 2021
Add support for versioned docker tags
93f8bac 
Fixes atmoz#291
@telmich telmich linked a pull request Nov 19, 2021 that will close this issue
Open
@telmich
Copy link
Author

telmich commented Jun 24, 2022

ping @atmoz - is this not of interest?

@dlehammer
Copy link

Seconded @telmich, all good points 👍

The way I see it, the current release "strategy" for atmoz/sftp provides zero traceability with regards to changes between releases ~ ie. what's changed between the last versioned release from 4 years ago, ex. alpine-3.7, and the 20h old unversioned alpine-tag ? (only the maintainers might know)
image

This approach is to unpredictable for me ~ resulting in a hard pass until remedied 🤓

@lambou123
Copy link

Are there any updates regarding this issue?
Is this correct, that using

  1. atmoz/sftp:alpine Tag uses the alpine:latest as base image
  2. atmoz/sftp:debian Tag uses the debian:bullseye as base image

If yes, using the debian image gives more predictability, but it's a bit bigger in size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for versioned docker tags ungleich/sftp
3 participants
@telmich @dlehammer @lambou123